diff options
| author | Yorhel <git@yorhel.nl> | 2019-05-25 08:47:19 +0200 |
|---|---|---|
| committer | Yorhel <git@yorhel.nl> | 2019-05-25 08:47:21 +0200 |
| commit | ce38ff885f82addfec198dc3611d970b97efeafd (patch) | |
| tree | f18a1b08e6eec951f23708672a17afbf09dc8342 | |
| parent | 2974ee929e83fee2c67dd9cc6482eb9c7cd6e965 (diff) | |
indexer: Don't overwrite man page contents when hash already exist
Performance improvement. The ON CONFLICT DO UPDATE was primarily to make
sure that old man pages would get fixed when the indexer did a better
job at detecting the encoding, but there haven't been any relevant fixes
to the indexer lately so this forced-update won't do much now.
| -rw-r--r-- | indexer/src/pkg.rs | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/indexer/src/pkg.rs b/indexer/src/pkg.rs index 2d725f9..93b7c14 100644 --- a/indexer/src/pkg.rs +++ b/indexer/src/pkg.rs @@ -119,12 +119,8 @@ fn insert_man(tr: &postgres::GenericConnection, verid: i32, paths: &[&str], ent: cont = cont.replace(0 as char, ""); } - // Overwrite entry if the contents are different. It's possible that earlier decoding - // implementations didn't properly detect the encoding. (On the other hand, due to differences - // in filenames it's also possible that THIS decoding step went wrong, but that's slightly less - // likely) tr.execute( - "INSERT INTO contents (hash, content) VALUES($1, $2) ON CONFLICT (hash) DO UPDATE SET content = $2", + "INSERT INTO contents (hash, content) VALUES($1, $2) ON CONFLICT (hash) DO NOTHING", &[&dig.as_ref(), &cont] ).unwrap(); |