summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYorhel <git@yorhel.nl>2022-09-14 12:51:09 +0200
committerYorhel <git@yorhel.nl>2022-09-14 12:51:52 +0200
commit46ca69ea78e8adb9ad73947b1f2da69b0934865a (patch)
treef1c02f3be0fd8ba57411a1c69907eb9983b2b866
parentbfebc800a5908ef7221e57d1252360b84f277182 (diff)
Fix buffer overflow on connections tab for incoming IPv6 connections in handshake phase
That code was never updated for IPv6.
-rw-r--r--src/uit_conn.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/src/uit_conn.c b/src/uit_conn.c
index 9e9fe58..28a0c81 100644
--- a/src/uit_conn.c
+++ b/src/uit_conn.c
@@ -117,16 +117,8 @@ static void t_draw_row(ui_listing_t *list, GSequenceIter *iter, int row, void *d
cc->state == CCS_IDLE ? 'I' : cc->dl ? 'D' : 'U');
mvaddch(row, 3, cc->tls ? 't' : ' ');
- if(cc->nick)
- mvaddnstr(row, 5, cc->nick, str_offset_from_columns(cc->nick, 15));
- else {
- char tmp[30];
- strcpy(tmp, "IP:");
- strcat(tmp, cc->remoteaddr);
- if(strchr(tmp+3, ':'))
- *(strchr(tmp+3, ':')) = 0;
- mvaddstr(row, 5, tmp);
- }
+ char *tmp = cc->nick ? cc->nick : cc->remoteaddr;
+ mvaddnstr(row, 5, tmp, str_offset_from_columns(tmp, 15));
if(cc->hub)
mvaddnstr(row, 21, cc->hub->tab->name, str_offset_from_columns(cc->hub->tab->name, 11));