summaryrefslogtreecommitdiff
path: root/src/sock.rs
blob: faccb462bc7ba397f04b607ff11b48882346ebdf (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
use std::io::{self,Read,Write};
use std::net::{TcpStream,SocketAddr};
use std::process::Child;
use std::sync::{Mutex,Condvar};

use crate::err::Result;


// Returns an error if the argument is not a "Keyword" in the control protocol. The control spec
// mentions several types of "keyword"s; It is used to specify command names, settings and GETINFO
// keys, and each seem to have different parsing rules. This function is intended to validate user
// input in order to prevent protocol injection. It is therefore lenient enough in that it allows
// for the different "keyword" contexts, but should still be strict enough to prevent the string
// from being interpreted as something other than a keyword.
fn is_keyword_char(c: char) -> bool { c.is_ascii_alphanumeric() || c == '/' || c == '-' || c == '_' || c == '.' }
fn is_keyword(s: &str) -> Result<()> {
    if s.contains(|c| !is_keyword_char(c)) {
        return Err(err!(Keyword, s.to_string()))
    }
    Ok(())
}

// Consume a prefix from a buffer. Handy utility function when parsing.
#[inline]
fn cons(buf: &mut &str, prefix: &str) -> Result<()> {
    if buf.starts_with(prefix) { *buf = &buf[prefix.len()..]; Ok(()) } else { Err(err!(Parse)) }
}

fn cons_keyword<'a>(buf: &mut &'a str) -> Result<&'a str> {
    let i = buf.find(|c| !is_keyword_char(c)).unwrap_or(buf.len());
    if i == 0 {
        Err(err!(Parse))
    } else {
        let s = &buf[..i];
        *buf = &buf[i..];
        Ok(s)
    }
}

fn cons_u8(buf: &mut &str) -> Result<u8> {
    let i = buf.find(|c:char| !c.is_ascii_digit()).unwrap_or(buf.len());
    let v = (&buf[..i]).parse().map_err(|_| err!(Parse))?;
    *buf = &buf[i..];
    Ok(v)
}


// A Reply (Sync or Async) consists of any number of intermediate lines (Mid/Data) followed by an
// End line.
type Reply = Vec<ReplyLine>;


#[derive(Debug,PartialEq)]
pub(crate) struct ReplyLine {
    len:    usize, // Length of this reply, in bytes, including the final CRLF
    status: u16,
    end:    bool,  // If this is a Mid/Data or End reply
    text:   String,
    data:   Vec<u8>
}


// Used in error message formatting
impl<'a> std::fmt::Display for ReplyLine {
    fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
        write!(f, "{} {}", self.status, self.text)
    }
}


impl ReplyLine {
    fn is_async(&self) -> bool {
        self.status >= 600 && self.status < 700
    }

    fn parse_data(buf: &[u8]) -> Option<(usize,Vec<u8>)> {
        // Yes, this actually does need an optimized find_bytes() implementation; With a naive
        // iterator it will take quite a while to parse `GETINFO md/all`.
        let mut off = match twoway::find_bytes(buf, b"\r\n.\r\n") {
            None => return None,
            Some(i) => i
        };
        let mut data = &buf[..off];
        off += 5;

        // Look for a "\r\n." sequence and remove the dot.
        let mut ndata = Vec::new();
        if data.len() > 0 && data[0] == b'.' {
            data = &data[1..];
        }
        while let Some(idx) = twoway::find_bytes(data, b"\r\n.") {
            ndata.extend_from_slice(&data[..idx+2]);
            data = &data[idx+3..];
        }
        ndata.extend_from_slice(data);
        Some((off, ndata))
    }

    // Returns None if there is not enough data in the buffer.
    fn parse(buf: &[u8]) -> Result<Option<ReplyLine>> {
        let mut off = match twoway::find_bytes(buf, b"\r\n") {
            None => return Ok(None),
            Some(i) if i < 4 => return Err(err!(Parse)),
            Some(i) => i
        };
        let line = &buf[..off];
        off += 2;

        let status : u16 = std::str::from_utf8(&line[..3]).map_err(|_| err!(Parse))?.parse().map_err(|_| err!(Parse))?;
        let end = match line[3] {
            b'-' => false,
            b'+' => false,
            b' ' => true,
            _ => return Err(err!(Parse)),
        };
        let text = std::str::from_utf8(&line[4..]).map_err(|_| err!(Parse))?;

        let data = if line[3] == b'+' {
            if let Some((len, d)) = Self::parse_data(&buf[off..]) {
                off += len;
                d
            } else {
                return Ok(None)
            }
        } else {
            Vec::new()
        };

        Ok(Some(ReplyLine {
            len:    off,
            status: status,
            end:    end,
            text:   text.to_string(),
            data:   data,
        }))
    }
}


/// Authentication method and credentials used to authenticate to the Tor control socket.
/// The `COOKIE` and `SAFECOOKIE` authentication methods are not supported.
pub enum Auth {
    /// Authenticate without credentials.
    Null,
    /// Authenticate with a password, this corresponds to the 'HashedControlPassword' configuration
    /// option in torrc. See `genpass()` and `hashpass()` for functions to generate a suitable
    /// password and `HashedControlPassword` combination.
    HashedPassword(String)
}


/// Status event of Tor's bootstrapping process.
#[derive(Debug)]
pub struct BootstrapStatus {
    /// Severity of this event. Typically `Notice` if all is going well, `Warn` if there are some
    /// problems.
    pub severity: Severity,
    /// Bootstrap progress in percent.
    pub progress: u8,
    /// Tor identifier for the current action.
    pub tag:      String, // TODO: Enum?
    /// Human readable description of the next action to take (e.g. "Handshaking with a relay").
    pub summary:  String,
    // TODO: warning/reason/count/recommendation
}


/// Tor log message severity.
#[derive(Debug,PartialEq,Eq,PartialOrd,Ord,Clone,Copy)]
pub enum Severity {
    Debug,
    Info,
    Notice,
    Warn,
    Err
}


/// An asynchronous event received from Tor. These are returned by `read_event()`.
#[derive(Debug)]
pub enum Event {
    /// Log messages
    Log(Severity, String),
    /// Bootstrap status event
    Bootstrap(Box<BootstrapStatus>),
}


/// A Builder type for the argument to `setevents()`. Use `EventList::default()` to initialize a
/// default (empty) event list.
///
/// ```
/// # use torctl::{EventList,Severity};
/// let log_warn_and_error = EventList::default().log(Severity::Notice);
/// ```
#[derive(Debug,Default,Clone,Copy)]
pub struct EventList {
    log:       Option<Severity>,
    bootstrap: bool,
}

impl EventList {
    /// Receive log messages matching the given severity or higher.
    pub fn log(mut self, lvl: Severity) -> Self { self.log = Some(lvl); self }

    /// Receive `Bootstrap` events.
    pub fn bootstrap(mut self) -> Self { self.bootstrap = true; self }

    fn cmd(&self) -> String {
        let mut s = "SETEVENTS".to_string();
        match self.log {
            Some(Severity::Debug)  => s.push_str(" ERR WARN NOTICE INFO DEBUG"),
            Some(Severity::Info)   => s.push_str(" ERR WARN NOTICE INFO"),
            Some(Severity::Notice) => s.push_str(" ERR WARN NOTICE"),
            Some(Severity::Warn)   => s.push_str(" ERR WARN"),
            Some(Severity::Err)    => s.push_str(" ERR"),
            None => (),
        }
        if self.bootstrap { s.push_str(" STATUS_CLIENT") }
        s.push_str("\r\n");
        s
    }
}



// A double-quoted string where only \ and " are escaped.
// Encoding: QuotedString("hello").to_string()
// Decoding: QuotedString::parse("\"hello\"")
struct QuotedString<'a>(&'a str);

impl<'a> std::fmt::Display for QuotedString<'a> {
    fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
        use std::fmt::Write;
        f.write_char('"')?;
        for c in self.0.chars() {
            if c == '"' || c == '\\' {
                f.write_char('\\')?;
            }
            f.write_char(c)?;
        }
        f.write_char('"')
    }
}

impl<'a> QuotedString<'a> {
    fn parse(s: &mut &str) -> Result<String> {
        cons(s, "\"")?;
        let mut out = String::new();
        let mut q = false;
        for (i, c) in s.char_indices() {
            match (q, c) {
                (true , _   ) => { q = false; out.push(c) },
                (false, '\\') => q = true,
                (false, '"' ) => { *s = &s[i+1..]; return Ok(out) },
                (false, _   ) => out.push(c),
            }
        }
        Err(err!(Parse))
    }
}




/// Tor control socket.
///
/// A socket is created either by connecting to an existing Tor process using `Sock::connect()`, or
/// by calling `spawn()` to spawn a new Tor process.
///
/// A socket can be used from multiple threads, with the following limitations:
/// - It is possible to run commands simultaneously from multiple threads, but the order in which
///   they are executed is, of course, not deterministic. Running a `setconf()` and `getconf()` on
///   the same keys at the same time may not give reliable results.
/// - You should only read asynchronous events from a single thread at a time. The API allows for
///   multiple threads to read events, but an event will only be received by one thread.
pub struct Sock {
    sock:    TcpStream,
    // Should be set when tor is running as a child process and this socket has "ownership" of the process.
    child:   Option<Child>,
    // Read buffer - only one thread can be reading from the socket at a time.
    rdbuf:   Mutex<Vec<u8>>,
    // Read queue - if multiple threads are interested in reading from the socket, then this
    // structure is used to coordinate which thread gets to read from the socket. If that thread
    // happens to read a reply that it isn't interested in (e.g. it expected a sync reply and got
    // an async one), then that reply is pushed to the queue.
    queue:   Mutex<SockQueue>,
    queuecv: Condvar,
    // Write mutex - this ensures only a single command can be sent at a time. This mutex is
    // currently also held while reading the response of a command, because the read queue itself
    // does not ensure that sync replies are consumed by different threads in the proper order.
    // (Could probably be fixed by keeping track of a command sequence - Tor does support
    // pipelining multiple commands, so this is a potential performance improvement)
    writer:  Mutex<bool>,
}

struct SockQueue {
    queue:   Vec<Reply>,
    reading: bool,
}


impl Drop for Sock {
    fn drop(&mut self) {
        // We have to wait() for the child to shut down, otherwise we get a zombie process. This is
        // a quick-and-dirty approach which doesn't really give Tor the time to do a clean
        // shutdown.  In fact, we kill the process before even shutting down the socket.
        // A cleaner "shut down socket and wait a bit" approach should probably be implemented as a
        // separate method.
        if let Some(mut c) = self.child.take() {
            c.kill().is_ok();
            c.wait().is_ok();
        }
    }
}


impl Sock {
    fn read_line(buf: &mut Vec<u8>, sock: &TcpStream) -> Result<ReplyLine> {
        // This buffer handling isn't very efficient, but that's probably fine.
        loop {
            if let Some(r) = ReplyLine::parse(&buf[..])? {
                buf.drain(..r.len);
                return Ok(r);
            }

            let mut rd = [0u8; 512];
            match (&*sock).read(&mut rd) {
                Err(ref e) if e.kind() == io::ErrorKind::Interrupted => (),
                Err(e) => return Err(e.into()),
                Ok(0) => return Err(io::Error::new(io::ErrorKind::UnexpectedEof, "Unexpected disconnect").into()),
                Ok(l) => buf.extend_from_slice(&rd[..l])
            }
        }
    }

    fn read_reply(buf: &mut Vec<u8>, sock: &TcpStream) -> Result<Reply> {
        let mut reply : Reply = Vec::new();
        while reply.last().map(|r| !r.end).unwrap_or(true) {
            reply.push(Self::read_line(buf, sock)?);
        }
        Ok(reply)
    }

    fn get_reply(&self, async_event: bool) -> Result<Reply> {
        // Check the queue to see if our reply has already been read.
        {
            let mut queue = self.queue.lock().unwrap();
            loop {
                if let Some(idx) = queue.queue.iter().position(|r| r[0].is_async() == async_event) {
                    return Ok(queue.queue.remove(idx))
                }
                // Nothing in the queue, but another thread is currently reading, so let's wait.
                if queue.reading {
                    queue = self.queuecv.wait(queue).unwrap();
                // Nothing in the queue and nobody else is reading, let's read from the socket.
                } else {
                    queue.reading = true;
                    break;
                }
            }
        }

        // We now have the read flag, so keep reading until we have our reply.
        let ret = loop {
            let mut buf = self.rdbuf.lock().unwrap();
            match Self::read_reply(&mut buf, &self.sock) {
                Err(e) => break Err(e),
                Ok(r) => {
                    if r[0].is_async() == async_event {
                        break Ok(r)
                    // This reply isn't for us, add it to the queue
                    } else {
                        self.queue.lock().unwrap().queue.push(r);
                        self.queuecv.notify_one();
                    }
                }
            }
        };
        self.queue.lock().unwrap().reading = false;
        self.queuecv.notify_one();
        ret
    }

    fn cmd<S: AsRef<[u8]>>(&self, cmd: S) -> Result<Reply> {
        let _guard = self.writer.lock().unwrap();

        (&self.sock).write_all(cmd.as_ref())?;
        let mut ret = self.get_reply(false)?;
        if ret[0].status >= 200 && ret[0].status < 300 {
            Ok(ret)
        } else {
            Err(err!(Status, ret.remove(0)))
        }
    }

    pub(crate) fn connect_child(s: &SocketAddr, auth: &Auth, child: Option<Child>) -> Result<Sock> {
        let sock = Sock {
            sock:    TcpStream::connect(s)?,
            child:   child,
            rdbuf:   Mutex::new(Vec::new()),
            queue:   Mutex::new(SockQueue {
                queue:   Vec::new(),
                reading: false,
            }),
            queuecv: Condvar::new(),
            writer:  Mutex::new(true),
        };

        match auth {
            Auth::Null => sock.cmd("AUTHENTICATE\r\n")?,
            Auth::HashedPassword(s) => sock.cmd(format!("AUTHENTICATE {}\r\n", QuotedString(s)))?
        };
        Ok(sock)
    }

    /// Connect to a running Tor process and authenticate using the given authentication method.
    pub fn connect(s: &SocketAddr, auth: &Auth) -> Result<Sock> {
        Self::connect_child(s, auth, None)
    }

    /// Send a TAKEOWNERSHIP command. If this command has been acknowledged, the Tor process
    /// will automatically shut down when this control socket is closed.
    ///
    /// Ownership is already implied if this socket has been created with the `spawn()` function,
    /// so in that case you do not have to call this method.
    pub fn takeownership(&self) -> Result<()> {
        self.cmd("TAKEOWNERSHIP\r\n").map(|_|())
    }

    /// Send a DROPOWNERSHIP command. This reverses any earlier TAKEOWNERSHIP command and tells
    /// the Tor process to keep running even after this control socket is closed.
    ///
    /// Note that, if this socket has been created with the `spawn()` function, then the Tor
    /// process will still be killed when the socket is dropped. This method is only useful when
    /// connected to an external Tor process.
    pub fn dropownership(&self) -> Result<()> {
        self.cmd("DROPOWNERSHIP\r\n").map(|_|())
    }

    /// Send a QUIT command. This tells Tor to close this control socket. Any further commands will
    /// likely result in an error.
    ///
    /// The Tor process will exit if this control socket has called `takeownership()` before.
    // TODO: Get rid of this function and implement a more thorough shutdown() instead?
    pub fn quit(&self) -> Result<()> {
        self.cmd("QUIT\r\n").map(|_|())
    }


    // XXX: This IntoIterator works with &[..] and &vec![..]. Haven't tested HashMap/BTreeMap yet,
    // but I suspect their signature doesn't match.
    fn setresetconf<'a,T>(&self, mut msg: String, settings: T) -> Result<()>
        where T: IntoIterator<Item = &'a (&'a str, Option<&'a str>)>,
    {
        use std::fmt::Write;
        for (k, v) in settings {
            is_keyword(k)?;
            msg.push(' ');
            msg.push_str(k);
            if let Some(v) = v {
                write!(msg, "={}", QuotedString(v)).is_ok();
            }
        }
        msg.push_str("\r\n");
        self.cmd(msg).map(|_|())
    }

    /// Send a SETCONF command.
    pub fn setconf<'a,T>(&self, settings: T) -> Result<()>
        where T: IntoIterator<Item = &'a (&'a str, Option<&'a str>)>
    {
        self.setresetconf("SETCONF".to_string(), settings)
    }

    /// Send a RESETCONF command.
    pub fn resetconf<'a,T>(&self, settings: T) -> Result<()>
        where T: IntoIterator<Item = &'a (&'a str, Option<&'a str>)>
    {
        self.setresetconf("RESETCONF".to_string(), settings)
    }

    /// Returns the configuration variables for the requested keys. The values are returned in the
    /// order they were requested. Some keys may return multiple values, these will be listed
    /// multiple times. Some keys may return `None` when are unset or default.  An error is
    /// returned if any of the requested keys does not exist.
    ///
    /// This method corresponds to the GETCONF command.
    pub fn getconf<'a,T: IntoIterator<Item = &'a &'a str>>(&self, keys: T) -> Result<Vec<(String, Option<String>)>> {
        let mut msg = "GETCONF".to_string();
        for k in keys {
            is_keyword(k)?;
            msg.push(' ');
            msg.push_str(k);
        }
        msg.push_str("\r\n");

        let mut res = Vec::new();
        for line in self.cmd(msg)? {
            if let Some(is) = line.text.find('=') {
                let mut val = &line.text[is+1..];
                let val = if val.starts_with('"') { QuotedString::parse(&mut val)? } else { val.to_string() };
                res.push(( (&line.text[..is]).to_string(), Some(val) ));
            } else {
                res.push((line.text, None));
            }
        }
        Ok(res)
    }

    /// Similar to the `getconf()` method, except this is used to get run-time variables that are
    /// not saved in the configuration. An error is returned if any of the requested keys does not
    /// exist.
    ///
    /// Corresponds to the GETINFO command. Refer to the GETINFO documentation in the [tor-control
    /// specification](https://gitweb.torproject.org/torspec.git/blob/control-spec.txt) for the
    /// list of accepted keys.
    pub fn getinfo<'a,T: IntoIterator<Item = &'a &'a str>>(&self, keys: T) -> Result<Vec<(String, String)>> {
        let mut msg = "GETINFO".to_string();
        for k in keys {
            is_keyword(k)?;
            msg.push(' ');
            msg.push_str(k);
        }
        msg.push_str("\r\n");

        let mut res = Vec::new();
        for line in self.cmd(msg)? {
            if line.text == "OK" {
                break;
            }
            if let Some(is) = line.text.find('=') {
                let val = if line.data.len() > 0 {
                    String::from_utf8(line.data).map_err(|_|err!(Parse))?
                } else {
                    (&line.text[is+1..]).to_string()
                };
                res.push(( (&line.text[..is]).to_string(), val ));
            } else {
                return Err(err!(Parse));
            }
        }
        Ok(res)
    }

    pub fn setevents(&self, events: EventList) -> Result<()> {
        self.cmd(events.cmd()).map(|_|())
    }

    /// Read an event from the socket. This method blocks until an event has been received.
    pub fn read_event(&self) -> Result<Event> {
        fn extract_sev(buf: &mut &str) -> Result<Severity> {
                 if cons(buf, "DEBUG " ).is_ok() { Ok(Severity::Debug ) }
            else if cons(buf, "INFO "  ).is_ok() { Ok(Severity::Info  ) }
            else if cons(buf, "NOTICE ").is_ok() { Ok(Severity::Notice) }
            else if cons(buf, "WARN "  ).is_ok() { Ok(Severity::Warn  ) }
            else if cons(buf, "ERR "   ).is_ok() { Ok(Severity::Err   ) }
            else { Err(err!(Parse)) }
        }

        loop {
            let mut ret = self.get_reply(true)?;
            let ev = ret.remove(0);
            let mut buf = &ev.text[..];

            if let Ok(sev) = extract_sev(&mut buf) {
                let s = if ev.data.is_empty() {
                    buf.trim().to_owned()
                } else {
                    String::from_utf8_lossy(&ev.data).trim().to_owned()
                };
                return Ok(Event::Log(sev, s))

            } else if cons(&mut buf, "STATUS_CLIENT ").is_ok() {
                let sev = extract_sev(&mut buf)?;
                if cons(&mut buf, "BOOTSTRAP ").is_ok() {
                    let mut bs = Box::new(BootstrapStatus {
                        severity: sev,
                        progress: 0,
                        tag:      String::new(),
                        summary:  String::new(),
                    });
                    // TODO: Can the order of these arguments change?
                    cons(&mut buf, "PROGRESS=")?;
                    bs.progress = cons_u8(&mut buf)?;
                    cons(&mut buf, " TAG=")?;
                    bs.tag = cons_keyword(&mut buf)?.to_owned();
                    cons(&mut buf, " SUMMARY=")?;
                    bs.summary = QuotedString::parse(&mut buf)?;
                    return Ok(Event::Bootstrap(bs))
                }
            }
        }
    }
}


#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn parse_replyline() {
        assert!(ReplyLine::parse(b"\r\n").is_err());
        assert!(ReplyLine::parse(b"250\r\n").is_err());
        assert!(ReplyLine::parse(b"2500 Text\r\n").is_err());
        assert!(ReplyLine::parse(b"250.Text\r\n").is_err());
        assert!(ReplyLine::parse(b".50 Text\r\n").is_err());
        assert!(ReplyLine::parse(b"-50 Text\r\n").is_err());
        assert!(ReplyLine::parse(b"01x Text\r\n").is_err());

        assert_eq!(ReplyLine::parse(b"").unwrap(), None);
        assert_eq!(ReplyLine::parse(b"250 Hello\r").unwrap(), None);
        assert_eq!(ReplyLine::parse(b"250+Hello\r\n").unwrap(), None);
        assert_eq!(ReplyLine::parse(b"250+Hello\r\ndata\r\n..a\r\n.\r").unwrap(), None);

        assert_eq!(ReplyLine::parse(b"250 \r\n").unwrap(), Some(ReplyLine { len: 6, status: 250, end: true, text: "".to_string(), data: Vec::new() }) );
        assert_eq!(ReplyLine::parse(b"650-Hello\r\n").unwrap(), Some(ReplyLine { len: 11, status: 650, end: false, text: "Hello".to_string(), data: Vec::new() }) );
        assert_eq!(ReplyLine::parse(b"650+Hello\r\n.data\r\n.\r\n").unwrap(), Some(ReplyLine { len: 21, status: 650, end: false, text: "Hello".to_string(), data: b"data".to_vec() }) );
        assert_eq!(ReplyLine::parse(b"650+Hello\r\ndata\r\n..\r\n.\r\n").unwrap(), Some(ReplyLine { len: 24, status: 650, end: false, text: "Hello".to_string(), data: b"data\r\n.".to_vec() }) );
    }

    #[test]
    fn qs_fmt() {
        assert_eq!(QuotedString("").to_string(), "\"\"".to_string());
        assert_eq!(QuotedString(" \\a\"b \x02").to_string(), "\" \\\\a\\\"b \x02\"".to_string());
    }

    #[test]
    fn qs_parse() {
        let mut s = "";
        assert!(QuotedString::parse(&mut s).is_err());
        let mut s = "\"";
        assert!(QuotedString::parse(&mut s).is_err());
        let mut s = "\" \\\"";
        assert!(QuotedString::parse(&mut s).is_err());
        let mut s = "abc";
        assert!(QuotedString::parse(&mut s).is_err());

        let mut s = "\"\"";
        assert_eq!(QuotedString::parse(&mut s).unwrap(), "".to_string());
        assert_eq!(s, "");

        let mut s = "\" \\\\a\\\"b \x02\"";
        assert_eq!(QuotedString::parse(&mut s).unwrap(), " \\a\"b \x02".to_string());
        assert_eq!(s, "");

        let mut s = "\"\\r\\n\" hey";
        assert_eq!(QuotedString::parse(&mut s).unwrap(), "rn".to_string());
        assert_eq!(s, " hey");
    }
}