Misc poll improvements

- Merged polls table into threads table. Not much of a
  storage/performance difference, and it's a bit simpler this way.
- Merged DB::Polls into DB::Discussions. Mainly because of the above
  change in DB structure.
- Add option to remove an existing poll.
- Allow preview and recast to be changed without deleting the votes
- Set preview option by default. Because personal preferences. :)
- Minor form validation differences

1 files changed, 11 insertions, 16 deletions

diff --git a/data/js/polls.js b/data/js/polls.js
index b34f0f7b..94a0bba2 100644
--- a/data/js/polls.js
+++ b/data/js/polls.js
@@ -1,26 +1,21 @@
-function addPoll() {
-  var a = byId('poll_add');
-  setClass(a, 'hidden', false);
+// Discussion board polls
+if(byId('jt_box_postedit') && byId('poll')) {
+  var c = byId('poll');
   var parentNode = function(n, tag) {
     while(n && n.nodeName.toLowerCase() != tag)
       n = n.parentNode;
     return n;
   };
   var show = function(v) {
-    setClass(parentNode(byId('poll_q'),      'tr'), 'hidden', !v);
-    setClass(parentNode(byId('poll_opt'),    'tr'), 'hidden', !v);
-    setClass(parentNode(byId('poll_max'),    'tr'), 'hidden', !v);
-    setClass(parentNode(byId('poll_preview'),'tr'), 'hidden', !v);
-    setClass(parentNode(byId('poll_recast'), 'tr'), 'hidden', !v);
-    setClass(parentNode(a, 'tr'), 'hidden', v);
+    setClass(parentNode(byId('poll_question'),    'tr'), 'hidden', !v);
+    setClass(parentNode(byId('poll_options'),     'tr'), 'hidden', !v);
+    setClass(parentNode(byId('poll_max_options'), 'tr'), 'hidden', !v);
+    setClass(parentNode(byId('poll_preview'),     'tr'), 'hidden', !v);
+    setClass(parentNode(byId('poll_recast'),      'tr'), 'hidden', !v);
   };
-  a.onclick = function() {
-    show(true);
+  c.onclick = function() {
+    show(this.checked);
     return true;
   };
-  show(false);
+  show(c.checked);
 }
-
-// Discussion board polls
-if(byId('poll_add'))
-  addPoll();