L10N: Intern blood_types/genders/(char|staff)_roles/discussion_boards

I definitely needed the Tie::IxHash thing for these.

3 files changed, 31 insertions, 110 deletions

diff --git a/data/global.pl b/data/global.pl
index b03d0dfb..7362ddea 100644
--- a/data/global.pl
+++ b/data/global.pl
@@ -81,7 +81,18 @@ our %S;
     in => 'Individual',
     ng => 'Amateur group',
   ),
-  discussion_boards => [qw|an db ge v p u|], # <- note that some properties of these boards are hard-coded
+  # Some discussion board properties are hardcoded, e.g.:
+  # - number of rows to show on /t
+  # - whether it needs mod access
+  # - whether it needs to be linked to a DB item.
+  discussion_boards => ordhash(
+    an => 'Announcements',
+    db => 'VNDB discussions',
+    ge => 'General discussions',
+    v  => 'Visual novels',
+    p  => 'Producers',
+    u  => 'Users',
+  ),
   vn_lengths => [
     # name          time             examples
     [ 'Unknown',    '',              ''                                                  ],
@@ -200,21 +211,33 @@ our %S;
     ero  => 'Sexual content',
     tech => 'Technical',
   ),
-  # The voiced, animated, and *_status fields are stored in the database by their (numeric) index.
   voiced          => [ 'Unknown', 'Not voiced', 'Only ero scenes voiced', 'Partially voiced', 'Fully voiced' ],
   animated        => [ 'Unknown', 'No animations', 'Simple animations', 'Some fully animated scenes', 'All scenes fully animated' ],
   wishlist_status => [ 'high', 'medium', 'low', 'blacklist' ],
   rlist_status    => [ 'Unknown', 'Pending', 'Obtained', 'On loan', 'Deleted' ], # 0 = hardcoded "unknown", 2 = hardcoded 'OK'
   vnlist_status   => [ 'Unknown', 'Playing', 'Finished', 'Stalled', 'Dropped' ],
-  blood_types     => [qw| unknown o a b ab |],
-  genders         => [qw| unknown m f b |],
-  char_roles      => [qw| main primary side appears |],
+  blood_types     => ordhash(qw{unknown Unknown o O a A b B ab AB}),
+  genders         => ordhash(unknown => 'Unknown or N/A', qw{m Male  f Female  b Both}),
+  char_roles      => ordhash(
+    main    => 'Protagonist',
+    primary => 'Main character',
+    side    => 'Side character',
+    appears => 'Makes an appearance'
+  ),
   atom_feeds => { # num_entries, title, id
     announcements => [ 10, 'VNDB Site Announcements', '/t/an' ],
     changes       => [ 25, 'VNDB Recent Changes', '/hist' ],
     posts         => [ 25, 'VNDB Recent Posts', '/t' ],
   },
-  staff_roles     => [qw|scenario chardesign art music songs director staff|],
+  staff_roles     => ordhash(
+    scenario   => 'Scenario',
+    chardesign => 'Character design',
+    art        => 'Artist',
+    music      => 'Composer',
+    songs      => 'Vocals',
+    director   => 'Director',
+    staff      => 'Staff',
+  ),
   poll_options    => 20, # max number of options in discussion board polls
 );
 
diff --git a/data/js/filter.js b/data/js/filter.js
index 5a66f1fa..c77820ab 100644
--- a/data/js/filter.js
+++ b/data/js/filter.js
@@ -597,19 +597,11 @@ function filVN() {
 }
 
 function filStaff() {
-  var gend = [
-    ['unknown', mt('_gender_unknown')],
-    ['m', mt('_gender_m')],
-    ['f', mt('_gender_f')],
-  ];
+  var gend = VARS.genders.slice(0, 3);
 
   // Insert seiyuu into the list of roles, before the "staff" role.
   var roles = VARS.staff_roles;
-  for(var i=0; i<roles.length; i++)
-    if(roles[i][0] == 'staff') {
-      roles.splice(i, 0, ['seiyuu', mt('_credit_seiyuu')]);
-      break;
-    }
+  roles.splice(-1, 0, ['seiyuu', 'Voice actor']);
 
   return [
     mt('_sbrowse_fil_title'),
diff --git a/data/lang.txt b/data/lang.txt
index 19f4a177..fcbee0e7 100644
--- a/data/lang.txt
+++ b/data/lang.txt
@@ -38,27 +38,6 @@ information.
 en : Unknown
 
 
-# Discussion board types
-
-:_dboard_an
-en : Announcements
-
-:_dboard_db
-en : VNDB Discussions
-
-:_dboard_ge
-en : General discussions
-
-:_dboard_v
-en : Visual novels
-
-:_dboard_p
-en : Producers
-
-:_dboard_u
-en : Users
-
-
 # Rating indications
 
 :_vote_1
@@ -92,51 +71,6 @@ en : excellent
 en : masterpiece
 
 
-# Blood types
-
-:_bloodt_o
-en : O
-
-:_bloodt_a
-en : A
-
-:_bloodt_b
-en : B
-
-:_bloodt_ab
-en : AB
-
-
-# Genders
-
-:_gender_unknown
-en : Unknown or N/A
-
-:_gender_m
-en : Male
-
-:_gender_f
-en : Female
-
-:_gender_b
-en : Both
-
-
-# Character roles
-
-:_charrole_main
-en : [quant,_1,Protagonist,Protagonists]
-
-:_charrole_primary
-en : Main [quant,_1,character,characters]
-
-:_charrole_side
-en : Side [quant,_1,character,characters]
-
-:_charrole_appears
-en : Makes an appearance
-
-
 
 
 #############################################################################
@@ -1171,34 +1105,6 @@ en : No results found
 #############################################################################
 # Handler::Staff
 
-# Built-in credits
-
-:_credit_scenario
-en : Scenario
-
-:_credit_chardesign
-en : Character design
-
-:_credit_music
-en : Composer
-
-:_credit_director
-en : Director
-
-:_credit_art
-en : Artist
-
-:_credit_songs
-en : Vocals
-
-:_credit_staff
-en : Staff
-
-:_credit_seiyuu
-en : Voice actor
-
-:_credit_other
-en : Other
 
 # Staff diff fields (/s+.+)