v2rw/filters: Add experimental validation + move compat to VNWeb

This is a minor start towards rewriting the filter logic in the new v2rw
code. Filters were never validated before (I didn't have a good
framework for it - now I do) and invalid filters would result in a 500.
The new validation code is not yet applied, but failed validations will
be logged so that I can see if it's working correctly.

I mean, what better way to test than to throw it in production?

I'll write new (and more flexible) SQL generation functions for these
filters later, so that v2rw code can get filtered results and I can make
a start on rewriting the pages that depend on the functionality. The
validation schema can also be used to validate the filters stored in the
DB, so I can use it to get rid of the complex handling of stored invalid
filters.

1 files changed, 4 insertions, 0 deletions

diff --git a/lib/VNWeb/Validation.pm b/lib/VNWeb/Validation.pm
index d40f42c6..4d398aac 100644
--- a/lib/VNWeb/Validation.pm
+++ b/lib/VNWeb/Validation.pm
@@ -37,6 +37,10 @@ TUWF::set custom_validations => {
     language    => { enum => \%LANGUAGE },
     gtin        => { required => 0, default => 0, func => sub { $_[0] = 0 if !length $_[0]; $_[0] eq 0 || gtintype($_[0]) } },
     rdate       => { uint => 1, func => \&_validate_rdate },
+    # A tri-state bool, returns undef if not present or empty, normalizes to 0/1 otherwise
+    undefbool   => { required => 0, default => undef, func => sub { $_[0] = $_[0] ? 1 : 0; 1 } },
+    # An array that may be either missing (returns undef), a single scalar (returns single-element array) or a proper array
+    undefarray  => sub { +{ required => 0, default => undef, type => 'array', scalar => 1, values => $_[0] } },
     # Accepts a user-entered vote string (or '-' or empty) and converts that into a DB vote number (or undef) - opposite of fmtvote()
     vnvote      => { required => 0, default => undef, regex => qr/^(?:|-|[1-9]|10|[1-9]\.[0-9]|10\.0)$/, func => sub { $_[0] = $_[0] eq '-' ? undef : 10*$_[0]; 1 } },
     # Sort an array by the listed hash keys, using string comparison on each key