diff options
| author | Yorhel <git@yorhel.nl> | 2020-07-29 11:16:44 +0200 |
|---|---|---|
| committer | Yorhel <git@yorhel.nl> | 2020-07-29 11:24:26 +0200 |
| commit | de0d6d2aa8746fc76109289a75d947fa6012f92f (patch) | |
| tree | 1211a8a7a4a938c72666f4f6bc0b8b0258acb58c /lib | |
| parent | 32b502511709afd45503779d5a1c38a1ada0f09c (diff) | |
Reports: Fix display of deleted threads
This actually hides a bigger problem: There's no way to uniquely link to
forum posts when posts can be deleted, because the (tid,num) identifier
will be re-used for later posts and the report will then point to a
completely different post.
Not trivial to fix, and hopefully not too much of a problem when you're
aware of it.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/VNWeb/Misc/Reports.pm | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/lib/VNWeb/Misc/Reports.pm b/lib/VNWeb/Misc/Reports.pm index d3872f93..66734902 100644 --- a/lib/VNWeb/Misc/Reports.pm +++ b/lib/VNWeb/Misc/Reports.pm @@ -103,7 +103,7 @@ sub report_ { txt_ $r->{ip}||'[anonymous]'; } br_; - lit_ $r->{title}; + lit_ $r->{title} || '[deleted]'; br_; txt_ $r->{reason}; div_ class => 'quote', sub { lit_ bb2html $r->{message} } if $r->{message}; @@ -171,6 +171,11 @@ TUWF::get qr{/report/list}, sub { p_ q{ Changing the status and/or adding a comment will add an entry to the log, so other mods can see what is going on. Everything on this page is only visible to moderators. }; + p_ q{ + BUG: Deleting a post from a thread (not "hiding", but actually deleting it) will cause reports + on that thread to refer to innocent posts that happen to get the same post number as the deleted post. + Not a huge problem, but something to be aware of when browsing through handled reports. + }; br_; br_; p_ class => 'browseopts', sub { |