Age | Commit message (Collapse) | Author | Files | Lines |
|
Yay!
There are no more request handlers in the VNDB::* namespace and no more
Javascript in data/js/. This cleans up a lot of old legacy code that
wasn't fun to maintain.
|
|
This was the last form in the old v2 code, so this allowed me to get rid
of the old form validation and generation abstractions.
The form is mostly a duplicate of the tag editing form, as expected.
It's really annoying to have to maintain pretty much duplicate code for
tags and traits, but there are just enough differences that the
complexity of sharing code or creating a new abstraction outweigh the
benefits. :(
|
|
This is a minor start towards rewriting the filter logic in the new v2rw
code. Filters were never validated before (I didn't have a good
framework for it - now I do) and invalid filters would result in a 500.
The new validation code is not yet applied, but failed validations will
be logged so that I can see if it's working correctly.
I mean, what better way to test than to throw it in production?
I'll write new (and more flexible) SQL generation functions for these
filters later, so that v2rw code can get filtered results and I can make
a start on rewriting the pages that depend on the functionality. The
validation schema can also be used to validate the filters stored in the
DB, so I can use it to get rid of the complex handling of stored invalid
filters.
|
|
The resolution field now works much like the engine field.
|
|
This is yak shaving. The new module doesn't have much value as it is,
apart from having a central place to define link formats. This new
enrich_extlinks() approach is also a bit more efficient in that it can
avoid separate SQL queries for multiple objects.
But the real reason for these changes is that I can use that %LINKS hash
table to automatically generate the links part in the edit summary and
it should (hopefully) also be useful to generate a more
convenient/streamlined Elm edit form.
|
|
|
|
|
|
https://vndb.org/t2520.307
|
|
This is the first major editing form to be converted, so I'm expecting a
little breakage. A good chunk of this code has been copied from v3.
In terms of the UI there has been a small change: aliases that are still
referenced do not have the 'remove' link and instead have a flag that
shows that they are still referenced. This ought to be a bit friendlier
than throwing an error message after the user has submitted the form.
Some other things I'd like to improve in this form:
- BBCode preview
- Pasting in external links and letting the form figure out the Pixiv
ID, etc.
- Or perhaps even: Integrate AniDB/Wikidata search/autocompletion.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The current affiliate links format doesn't display as much information
as before but it's also a lot less messy.
|
|
|
|
|
|
|
|
It's redundant, and normalization is actually easier when removed.
|
|
|
|
This allows for easy insertion of affiliate referral tag.
|
|
Full URL, because DMM has too many little sub-shops, and handling them
all is a pain. I assume for now that a release is only in a single DMM
shop.
|
|
|
|
MG has an all-ages section at / and an adult section at /r18/, but the
adult section includes everything, so we'll just link to that. Maybe
I'll write a bot that figures out the correct link, but it's not
something we have to bother our users with.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This ended up being more common than I had expected, so let's properly
handle it now.
|
|
I should not be coding when tired. Keep missing all kinds of details.
|
|
|
|
+ Automatically fetch other links from Wikidata
|
|
Fixes #4.
|
|
This also abstracts and changes the tag/trait filter selection interface
a little bit. Non-searchable tags/traits are now simply not listed
anymore in the dropdown search.
|
|
As discussed in https://vndb.org/t12507
TODO:
- Same conversion for traits
- Re-add mod ability to delete all votes for a particular tag?
|
|
Compatability is hard...
|
|
filFetchDB() is not used for the release filter on the VN browsing
interface, so I've moved the compatibility stuff into a separate
filCompat() method that can be called from Handler::VNBrowse.
|
|
Been wanting to do this for a long time - using an integer index into an
array that changes once in a while is way too fragile. Doubly so when
said indices are also used in filters and URLs that can't be updated
every time a new resolution is added.
|
|
As discussed in https://vndb.org/t10665
|
|
|
|
|
|
|
|
|
|
|