From 6ff1efe0d07e24e9fb2db199c308c6cbed51e578 Mon Sep 17 00:00:00 2001 From: Yorhel Date: Thu, 23 Dec 2010 12:51:35 +0100 Subject: Converted the show_list pref. to users_prefs and inverted the value In the users_prefs table, the default value should evaluate to 'false' in Perl, so show_list had to be inverted to hide_list. --- lib/VNDB/Handler/ULists.pm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'lib/VNDB/Handler/ULists.pm') diff --git a/lib/VNDB/Handler/ULists.pm b/lib/VNDB/Handler/ULists.pm index d9051347..cb164277 100644 --- a/lib/VNDB/Handler/ULists.pm +++ b/lib/VNDB/Handler/ULists.pm @@ -115,10 +115,11 @@ sub rlist_e { sub votelist { my($self, $type, $id) = @_; - my $obj = $type eq 'v' ? $self->dbVNGet(id => $id)->[0] : $self->dbUserGet(uid => $id)->[0]; + my $obj = $type eq 'v' ? $self->dbVNGet(id => $id)->[0] : $self->dbUserGet(uid => $id, what => 'hide_list')->[0]; return 404 if !$obj->{id}; my $own = $type eq 'u' && $self->authInfo->{id} && $self->authInfo->{id} == $id; + return 404 if $type eq 'u' && !$own && ($obj->{hide_list} || $self->authCan('usermod')); my $f = $self->formValidate( { name => 'p', required => 0, default => 1, template => 'int' }, @@ -220,8 +221,8 @@ sub wishlist { my($self, $uid) = @_; my $own = $self->authInfo->{id} && $self->authInfo->{id} == $uid; - my $u = $self->dbUserGet(uid => $uid)->[0]; - return 404 if !$u || !$own && !($u->{show_list} || $self->authCan('usermod')); + my $u = $self->dbUserGet(uid => $uid, what => 'hide_list')->[0]; + return 404 if !$u || !$own && ($u->{hide_list} || $self->authCan('usermod')); my $f = $self->formValidate( { name => 'p', required => 0, default => 1, template => 'int' }, @@ -322,8 +323,8 @@ sub vnlist { my($self, $uid) = @_; my $own = $self->authInfo->{id} && $self->authInfo->{id} == $uid; - my $u = $self->dbUserGet(uid => $uid)->[0]; - return 404 if !$u || !$own && !($u->{show_list} || $self->authCan('usermod')); + my $u = $self->dbUserGet(uid => $uid, what => 'hide_list')->[0]; + return 404 if !$u || !$own && ($u->{hide_list} || $self->authCan('usermod')); my $f = $self->formValidate( { name => 'p', required => 0, default => 1, template => 'int' }, -- cgit v1.2.3